Skip to content

interconnect: qcom: Shikra epss L3 bindings update#702

Open
rlaggysh wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
rlaggysh:shikra_qli
Open

interconnect: qcom: Shikra epss L3 bindings update#702
rlaggysh wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
rlaggysh:shikra_qli

Conversation

@rlaggysh

@rlaggysh rlaggysh commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Shikra interconnect and epss L3 scaling changes from upstream
qli-2.0 GA Critical Fix

CRs-Fixed: 4569044
Link: https://lore.kernel.org/all/20260603-shikra_epss_l3-v3-0-3c2e0b796e78@oss.qualcomm.com/
Link: https://lore.kernel.org/all/20260526-shikra_icc_kconfig-v1-1-c589db2d023c@oss.qualcomm.com/

rlaggysh added 2 commits June 11, 2026 15:52
@rlaggysh
BACKPORT: FROMLIST: dt-bindings: interconnect: qcom,osm-l3: Add EPSS …
c1450bd 
…L3 DT binding for Qualcomm Shikra SoC

Document the EPSS L3 interconnect provider binding for Qualcomm
Shikra SoC.

The Shikra EPSS L3 block is similar to existing Qualcomm EPSS/OSM L3
providers, but supports only up to 12 frequency lookup table entries.

Co-developed-by: Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>
Signed-off-by: Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>
Signed-off-by: Raviteja Laggyshetty <raviteja.laggyshetty@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260603-shikra_epss_l3-v3-1-3c2e0b796e78@oss.qualcomm.com
@rlaggysh
FROMLIST: interconnect: qcom: Enable Shikra interconnect driver by de…
99285a9 
…fault for ARCH_QCOM

Interconnect drivers provide fundamental NoC bandwidth management
required for correct system behavior. Although systems can boot without
them, power and performance are impacted.
These drivers need to enabled irresepective of the board variant, design
or configuration.

Enable the Shikra interconnect driver by default on ARCH_QCOM by setting
 "default ARCH_QCOM".

Signed-off-by: Raviteja Laggyshetty <raviteja.laggyshetty@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260526-shikra_icc_kconfig-v1-1-c589db2d023c@oss.qualcomm.com
@qlijarvis

qlijarvis commented Jun 11, 2026

Copy link
Copy Markdown

PR #702 — validate-patch

PR: #702

Verdict Issues Detailed Report
⚠️ 3 Full report

Final Summary

  1. Lore link present: Yes — Both patches include proper lore.kernel.org Link: tags with message-IDs
  2. Lore link matches PR commits: Cannot verify — Network access restricted; unable to fetch upstream patches for byte-by-byte comparison
  3. Upstream patch status: In review — Both marked FROMLIST, indicating posted to mailing list but not yet merged; Patch 1 is v3 (active iteration), Patch 2 is v1
  4. PR present in qcom-next: Not checked — No kernel tree access per constraints

Recommendation: Request author to:

  • Fix typos in Patch 2 commit message
  • Clarify BACKPORT: prefix in Patch 1 (drop if clean cherry-pick, or add backport rationale)
  • Verify diffs match upstream exactly before merge
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #702 - Shikra EPSS L3 interconnect dt-bindings and Kconfig updates
Upstream commits:

Patch 1/2: dt-bindings: interconnect: qcom,osm-l3

Commit Message

Check Status Note
Subject matches upstream ⚠️ Has BACKPORT: prefix; upstream likely doesn't
Body preserves rationale ✅ Clear description of Shikra EPSS L3 support
Fixes tag present/correct N/A Not a fix; new feature
Authorship preserved ✅ Co-developed-by + dual Signed-off-by correct
Backport note (if applicable) ⚠️ BACKPORT: prefix present but no explanation why

Diff

File Status Notes
Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml ✅ Adds qcom,shikra-epss-l3 to compatible enum
Documentation/devicetree/bindings/interconnect/qcom,shikra-epss-l3.yaml ✅ Deletes standalone binding (consolidation)

Patch 2/2: interconnect: qcom: Enable Shikra interconnect driver

Commit Message

Check Status Note
Subject matches upstream ✅ FROMLIST: prefix appropriate for pending upstream
Body preserves rationale ⚠️ Typo: "irresepective" → "irrespective"; "enabled" → "be enabled"
Fixes tag present/correct N/A Not a fix; configuration change
Authorship preserved ✅ Single author, proper Signed-off-by
Backport note (if applicable) N/A FROMLIST indicates pending upstream

Diff

File Status Notes
drivers/interconnect/qcom/Kconfig ✅ Adds default ARCH_QCOM to INTERCONNECT_QCOM_SHIKRA

Issues

Patch 1:

  1. BACKPORT: prefix without context — Subject has BACKPORT: FROMLIST: but commit body doesn't explain what was backported or why. If this is a clean cherry-pick from an upstream series, BACKPORT: may be unnecessary.
  2. Tag order — Correct: Co-developed-by → Signed-off-by (co-author) → Signed-off-by (author) → Reviewed-by → Link. ✅

Patch 2:

  1. Typo in commit message — "irresepective" should be "irrespective"
  2. Grammar — "need to enabled" should be "need to be enabled"
  3. Tag order — Correct: Signed-off-by → Reviewed-by → Link. ✅

Both patches:

  • Lore links present and properly formatted ✅
  • Reviewed-by tags from maintainers (Krzysztof Kozlowski, Konrad Dybcio) ✅
  • Link tags follow kernel convention (placed after all other tags) ✅

Verdict

Patch 1: Merge with minor clarification — The BACKPORT: prefix suggests this differs from upstream, but the diff appears to be a clean consolidation. If this matches the upstream v3 series exactly, consider dropping BACKPORT: or adding a note explaining the backport context.

Patch 2: Fix typos before merge — Two spelling/grammar errors in commit message should be corrected: "irresepective" → "irrespective" and "need to enabled" → "need to be enabled".

Final Summary

  1. Lore link present: Yes — Both patches include proper lore.kernel.org Link: tags with message-IDs
  2. Lore link matches PR commits: Cannot verify — Network access restricted; unable to fetch upstream patches for byte-by-byte comparison
  3. Upstream patch status: In review — Both marked FROMLIST, indicating posted to mailing list but not yet merged; Patch 1 is v3 (active iteration), Patch 2 is v1
  4. PR present in qcom-next: Not checked — No kernel tree access per constraints

Recommendation: Request author to:

  • Fix typos in Patch 2 commit message
  • Clarify BACKPORT: prefix in Patch 1 (drop if clean cherry-pick, or add backport rationale)
  • Verify diffs match upstream exactly before merge

@qlijarvis

qlijarvis commented Jun 11, 2026

Copy link
Copy Markdown

PR #702 — checker-log-analyzer

PR: #702
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27343473289

Checker Result Summary
Checker Result Summary
checkpatch ❌ 1 warning: DT binding docs and includes should be separate patch
dt-binding-check ✅ Passed
dtb-check ⏭️ Skipped (no DT changes)
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ Patch differs from upstream lore link
tag-check N/A Not applicable (FROMLIST commits)
qcom-next-check ✅ FROMLIST:/BACKPORT: prefixes present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #702 - FROMLIST: dt-bindings and interconnect driver for Qualcomm Shikra SoC
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27343473289

Checker Result Summary
checkpatch ❌ 1 warning: DT binding docs and includes should be separate patch
dt-binding-check ✅ Passed
dtb-check ⏭️ Skipped (no DT changes)
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ Patch differs from upstream lore link
tag-check N/A Not applicable (FROMLIST commits)
qcom-next-check ✅ FROMLIST:/BACKPORT: prefixes present

❌ checkpatch

Root cause: Commit c1450bd modifies both DT binding YAML and deletes a separate binding file in a single patch, violating the kernel DT binding submission guidelines.

Failure details:

WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst

c1450bd943c0a5c43990d50d2b6adf6edb34cb12 total: 0 errors, 1 warnings, 0 checks, 8 lines checked

Fix: This is a non-blocking warning for FROMLIST/BACKPORT patches. The upstream patch at https://lore.kernel.org/r/20260603-shikra_epss_l3-v3-1-3c2e0b796e78@oss.qualcomm.com likely combines the binding changes intentionally. For internal trees, this warning can be safely ignored when backporting patches that were already reviewed and accepted upstream with this structure.

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git <base_sha>..c1450bd943c0

❌ check-patch-compliance

Root cause: The first commit (c1450bd) contains changes that differ from the upstream patch referenced in the Link trailer.

Failure details:

Checking commit: BACKPORT: FROMLIST: dt-bindings: interconnect: qcom,osm-l3: Add EPSS L3 DT binding for Qualcomm Shikra SoC
Change is different from the one mentioned in Link

Fix: The check-patch-compliance checker downloads the patch from the lore.kernel.org link and compares it byte-by-byte with the commit in the PR. The failure indicates one of:

  1. BACKPORT modifications: The commit is prefixed with BACKPORT:, suggesting intentional modifications were made to adapt the upstream patch to this kernel version. This is expected behavior for backports.

  2. Context differences: The patch may have been rebased or adapted for conflicts with the target branch.

  3. Metadata differences: Trailers, commit message formatting, or whitespace may differ.

Action required: Review the diff between the PR commit and the upstream lore patch to confirm the differences are intentional backport adaptations. If the changes are legitimate backport modifications, this failure can be accepted as expected for BACKPORT-tagged commits.

Reproduce locally:

# Download the upstream patch
b4 am https://lore.kernel.org/r/20260603-shikra_epss_l3-v3-1-3c2e0b796e78@oss.qualcomm.com

# Compare with local commit
git show c1450bd943c0 > /tmp/local.patch
git diff --no-index /tmp/upstream.patch /tmp/local.patch

Verdict

2 blockers identified, but both may be acceptable for BACKPORT/FROMLIST commits:

  1. checkpatch warning - Non-blocking style warning about combining DT binding changes. Safe to ignore for backports that preserve upstream structure.

  2. check-patch-compliance failure - Expected for BACKPORT: prefixed commits that contain intentional modifications. Requires manual review to confirm differences are legitimate adaptations.

Recommendation: Review the actual differences between the PR commits and their upstream lore links. If the modifications are intentional backport adaptations (e.g., resolving conflicts, adjusting for API differences), these failures are acceptable and the PR can proceed to merge after maintainer review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yijiyang yijiyang Awaiting requested review from yijiyang yijiyang was automatically assigned from qualcomm-linux/qualcomm-kernel-maint

@mukeshojha-linux mukeshojha-linux Awaiting requested review from mukeshojha-linux mukeshojha-linux was automatically assigned from qualcomm-linux/qualcomm-kernel-maint

@jingyiwang42 jingyiwang42 Awaiting requested review from jingyiwang42 jingyiwang42 was automatically assigned from qualcomm-linux/qualcomm-kernel-maint

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rlaggysh @qlijarvis